From e40ee885207f2a9d8352a56fce304f6bd4ed44f7 Mon Sep 17 00:00:00 2001
From: Julian Prein <druckdev@protonmail.com>
Date: Tue, 12 Jul 2022 20:46:43 +0200
Subject: [PATCH] meta:hooks:pre-push: Refactor if-condition

---
 meta/git/hooks/pre-push | 33 +++++++++++++++------------------
 1 file changed, 15 insertions(+), 18 deletions(-)

diff --git a/meta/git/hooks/pre-push b/meta/git/hooks/pre-push
index bfe059a..5338ac2 100755
--- a/meta/git/hooks/pre-push
+++ b/meta/git/hooks/pre-push
@@ -27,27 +27,24 @@ url="$2"
 zero=$(git hash-object --stdin </dev/null | tr '[0-9a-f]' '0')
 
 while read local_ref local_oid remote_ref remote_oid; do
-	if [ "$local_oid" = "$zero" ]; then
-		# Handle delete
-		:
+	[ "$local_oid" != "$zero" ] || continue
+
+	if [ "$remote_oid" = "$zero" ]; then
+		# New branch, examine all commits
+		range="$local_oid"
 	else
-		if [ "$remote_oid" = "$zero" ]; then
-			# New branch, examine all commits
-			range="$local_oid"
-		else
-			# Update to existing branch, examine new commits
-			range="$remote_oid..$local_oid"
-		fi
+		# Update to existing branch, examine new commits
+		range="$remote_oid..$local_oid"
+	fi
 
-		# Check for WIP or auto{squash,fixup} commit
-		pattern='^(WIP|(fixup|squash)!)'
+	# Check for WIP or auto{squash,fixup} commit
+	pattern='^(WIP|(fixup|squash)!)'
 
-		commits="$(git rev-list -E --oneline --grep "$pattern" "$range")"
-		if [ -n "$commits" ]; then
-			printf >&2 "$local_ref: Commits in progress:\n%s" "$commits"
-			printf >&2 "Aborting push"
-			exit 1
-		fi
+	commits="$(git rev-list -E --oneline --grep "$pattern" "$range")"
+	if [ -n "$commits" ]; then
+		printf >&2 "$local_ref: Commits in progress:\n%s" "$commits"
+		printf >&2 "Aborting push"
+		exit 1
 	fi
 done